fix: PlatformColor crashes on iOS and Android #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing this! |
WoLewicki
changed the title
91 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up PR to #1561 fixing the problems mentioned there. Also fixing the wrong releasing introduced in 027b8c1 by releasing this: 027b8c1#diff-bcb25a544c75891fb4ee3fa69a80e9bfdf9f4c60853971e9eeb21ba06a63de7aR90 here: 027b8c1#diff-bcb25a544c75891fb4ee3fa69a80e9bfdf9f4c60853971e9eeb21ba06a63de7aR97.
Thanks to @gaodeng for providing fixes for
Androidandtsfiles in oblador#1 (which also addsDynamicColorIOSoption and should be considered for merging).Test Plan
SampleTest.tsxinTestsExampleapp with and without native changes to see the crashes appear.Checklist