Unwrap Context in order to retrieve Activity subclass #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes crash on Expo client which is wrapping Activity prior to passing it as a context to the root view.
tsapeta
added a commit
to expo/expo
that referenced
this pull request
Jan 16, 2019
# Why Fixes #3191 # How Applied changes from software-mansion/react-native-screens#59 # Test Plan Apps in SDK32 can now be launched without red screen of death.
tsapeta
added a commit
to expo/expo
that referenced
this pull request
Jan 17, 2019
# Why Fixes #3191 # How Applied changes from software-mansion/react-native-screens#59 # Test Plan Apps in SDK32 can now be launched without red screen of death.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes crash on Expo client which is wrapping Activity prior to passing it as a context to the root view.
After my recent change in the logic on how we access main activity we know extract the reference to it using
getContextfrom the root view. Previously we were usinggetTopLevelActivitywhich wasn't working well in the cases where other non-react-native activities were transitioning in or out. The new approach however turned out not to be the best as for example expo client does not pass activity instance as a context directly to the root view. Instead the activity class is wrapped in ContextThemeWrapper (see it here).We now try to unwrap the context if it is not a fragment activity using
getBaseContextThis fixes expo/expo#3191