fix(iOS): add missing largeTitleBackgroundColor prop #2500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
kkafar
changed the title
kkafar
approved these changes
Nov 14, 2024
kkafar
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Description - requires this bug fix #2500 - make it possible to support the stock Apple behavior where the large header is transparent and the collapsed header is blurry with a shadow. This is currently not possible because we inherit the blur effect from the collapsed title, and because there's no way to set the headerLargeTitle blur effect. With this change, the default iOS behavior can more closely be matched by using the following props: ```js { headerLargeTitle: true, headerTransparent: true, headerBlurEffect: "systemChromeMaterial", headerLargeTitleShadowVisible: false, headerShadowVisible: true, headerLargeStyle: { // NEW: Make the large title transparent to match the background. backgroundColor: "transparent", }, } ``` Without the shadow changes, users also need to add this (and adjust for dark mode): ``` { headerStyle: { // Hack to ensure the collapsed small header shows the shadow / border. backgroundColor: "rgba(255,255,255,0.01)", }, } ``` ## Changes ### Before This is the best we can currently do.  ### After https://github.com/user-attachments/assets/b1e8999d-14ce-40ef-aef6-2478a9e6326c <!-- Please describe things you've changed here, make a **high level** overview, if change is simple you can omit this section. For example: - Updated `about.md` docs --> <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. --> ## Test code and steps to reproduce <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) --> ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Updated documentation: <!-- For adding new props to native-stack --> - [ ] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [ ] Ensured that CI passes
EvanBacon
deleted the
@evanbacon/fix-ios-large-title-background-color
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Test code and steps to reproduce
Checklist