chore: make eps parameter const & functions constexpr in RectUtil #2195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alduzy
approved these changes
Jun 19, 2024
alduzy
pushed a commit
that referenced
this pull request
Jun 28, 2024
) ## Description The `eps` parameter in `compareFrameSizes` should be `const`. Both functions can be `constexpr` so I've marked them as such. > [!note] When doing a bit of research for this PR I've learned that [`constexpr` implies `inline` linkage (so also bending the ODR rule)](https://stackoverflow.com/a/14391320/8635522) for functions (and it seems that since C++17 also for namespace scoped variables) and must admit I was not aware of this before, thus I've come to conclusion that it will be ok to leave `inline` keyword there, so that the intent of `inline` linkage is clear. ## Test code and steps to reproduce Build Android / iOS ## Checklist - [ ] Ensured that CI passes
This was referenced Aug 23, 2024
This was referenced Aug 27, 2024
This was referenced Sep 24, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…ftware-mansion#2195) ## Description The `eps` parameter in `compareFrameSizes` should be `const`. Both functions can be `constexpr` so I've marked them as such. > [!note] When doing a bit of research for this PR I've learned that [`constexpr` implies `inline` linkage (so also bending the ODR rule)](https://stackoverflow.com/a/14391320/8635522) for functions (and it seems that since C++17 also for namespace scoped variables) and must admit I was not aware of this before, thus I've come to conclusion that it will be ok to leave `inline` keyword there, so that the intent of `inline` linkage is clear. ## Test code and steps to reproduce Build Android / iOS ## Checklist - [ ] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
epsparameter incompareFrameSizesshould beconst.Both functions can be
constexprso I've marked them as such.Note
When doing a bit of research for this PR I've learned that
constexprimpliesinlinelinkage (so also bending the ODR rule) for functions (and it seems that since C++17 also for namespace scoped variables) and must admit I was not aware of this before, thus I've come to conclusion that it will be ok to leaveinlinekeyword there, so that the intent ofinlinelinkage is clear.Test code and steps to reproduce
Build Android / iOS
Checklist