fix: error when building paper after fabric #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciekstosio
changed the title
kkafar
reviewed
May 20, 2024
There was a problem hiding this comment.
Yeah I think we are good here.
Before merging I would recommend creating fresh RN application, installing @react-navigation/native-stack, react-native-safe-area-context & our library from sourcecode & build Paper Android.
I'm wary here after recent release issues.
Yeah, I packed the lib w |
tboba
approved these changes
May 20, 2024
maciekstosio
deleted the
@maciekstosio/fix-errors-when-building-paper-after-fabric
branch
This was referenced Jul 17, 2024
This was referenced Jul 25, 2024
This was referenced Aug 20, 2024
This was referenced Aug 23, 2024
This was referenced Aug 30, 2024
This was referenced Sep 24, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
## Description Currently when you build Fabric app and then Paper app Android Studio has errors about duplicated classes. This should resolve that issue. **Test:** Packed with `npm pack` and tested on new expo app. Seems that everything is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when you build Fabric app and then Paper app Android Studio has errors about duplicated classes. This should resolve that issue.
Test:
Packed with
npm packand tested on new expo app. Seems that everything is fine.