Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: improve Kotlin code #1558

Merged
merged 65 commits into from
Sep 16, 2022
Merged

style: improve Kotlin code #1558

merged 65 commits into from
Sep 16, 2022

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Aug 13, 2022 •
edited
Loading

Description

This PR aims to improve Kotlin style in library's codebase.

Changes

Many syntax related changes, including:

Test code and steps to reproduce

Run any of the example applications and see that no behaviour is changed.

Checklist

  • Ensured that CI passes

kkafar added 18 commits August 11, 2022 13:57
@kkafar
chore: add method for resolving appropriate fragment manager
3d497f8
@kkafar
fix: resolve appropriate fragment manager
843877a
@kkafar
refact: change method name
caa9bc8
@kkafar
chore: make return type non nullable
14447e8
@kkafar
chore: clarify comments & simplify logic
b8067da
@kkafar
chore: refactor code & add checks
94ff164
@kkafar
fix: typo
085358b
@kkafar
refact: another typo
20ca3fe
@kkafar
chore: take advantage of FragmentManager#findFragment method
67c1220 
Also add some comments that describe the changes
@kkafar
chore: add link to the issue
986b65c
@kkafar
refact: use checkNotNull in place of explicit comparision against null
fa9a43f
@kkafar
style: Kotlin
8c8429d
@kkafar
refact: ScreenContainer#createTransaction
539ad64
@kkafar
refact: ScreenContainer#{getActivityState,hasScreen}
256721b
@kkafar
refact: ScreenContainer#getScreenAt
07c6674
@kkafar
refact: ScreenContainer#removeMyFragments
a4e52b8
@kkafar
refact: ScreenContainer#topScreen
37bdbd8
@kkafar
refact: ScreenContainer#onMeasure
ed743e8
@kkafar kkafar changed the base branch from main to @kkafar/fix-1506 August 13, 2022 22:18
@kkafar kkafar marked this pull request as ready for review August 14, 2022 14:06
@kkafar kkafar force-pushed the @kkafar/improve-kotlin branch from de41f4d to 6011a75 Compare August 14, 2022 14:25
@kkafar kkafar marked this pull request as draft August 14, 2022 14:26
@kkafar kkafar marked this pull request as ready for review August 15, 2022 10:28
@kkafar kkafar requested review from kacperkapusciak and WoLewicki and removed request for kacperkapusciak August 16, 2022 07:13
WoLewicki
WoLewicki approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left some comments, please answer them before merging.

android/src/main/java/com/swmansion/rnscreens/ScreenFragment.kt Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/ScreenStackFragment.kt Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/ScreenStackFragment.kt Show resolved Hide resolved
Base automatically changed from @kkafar/fix-1506 to main August 16, 2022 11:39
@kkafar kkafar requested a review from j-piasecki August 19, 2022 08:37
j-piasecki
j-piasecki reviewed Aug 19, 2022
View reviewed changes
android/src/main/java/com/swmansion/rnscreens/Screen.kt Outdated Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/ScreenContainer.kt Outdated Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/ScreenStack.kt Outdated Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderConfig.kt Outdated Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderConfig.kt Outdated Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderConfig.kt Outdated Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/ScreenStackViewManager.kt Outdated Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/RNSUtil.kt Outdated Show resolved Hide resolved
@kkafar kkafar changed the title style: Kotlin style: improve Kotlin code Sep 15, 2022
@kkafar
chore: merge in main
c8543d7 
Merge branch 'main' into @kkafar/improve-kotlin
@kkafar kkafar merged commit 870007d into main Sep 16, 2022
@kkafar kkafar deleted the @kkafar/improve-kotlin branch September 16, 2022 13:22
This was referenced Oct 5, 2022
Closed
Closed
@moul-bot moul-bot mentioned this pull request Oct 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-piasecki j-piasecki j-piasecki left review comments

@WoLewicki WoLewicki WoLewicki approved these changes

@kacperkapusciak kacperkapusciak Awaiting requested review from kacperkapusciak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkafar @j-piasecki @WoLewicki