Enable supportsLocking in createWorkletRuntime
#7033
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 16, 2025
Closed
piaskowyk
approved these changes
Feb 17, 2025
tomekzaw
added a commit
that referenced
this pull request
Feb 19, 2025
This PR changes the value of `supportsLocking` argument passed to `WorkletRuntime` constructor from `false` to `true` in order to fix crash when using `WorkletRuntime` simultaneously from multiple threads. Fixes Expensify/react-native-live-markdown#616.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the value of
supportsLockingargument passed toWorkletRuntimeconstructor fromfalsetotruein order to fix crash when usingWorkletRuntimesimultaneously from multiple threads.Fixes Expensify/react-native-live-markdown#616.
Test plan