-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for boxShadow #6749
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix CI and we are good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go a bit further. Let's see how boxShadow
fares in both Jest and our runtime tests.
...
…Shadow Runtime test is disabled for now
400f0ce
to
5fa603a
Compare
8f2f601
to
e43a655
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go!! 🥳
Summary
This PR introduces support for boxShadow - a new feature from React Native 0.76+ NewArch. At the same time it address #6687 .
boxShadow
prop, that transforms string into aboxShadow
object.withSpring
Runtime test are added for future fabric support in RuntimeTests.
Fixes #6687
Screen.Recording.2024-11-22.at.16.23.44.mov
Test plan
To test, paste this code snippet to
EmptyExample
and run.EmptyExample code