Lazy initalize layout aniamtions in the Commit Hook #6586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomiejbloniarz
requested review from
tomekzaw,
tjzel and
piaskowyk
and removed request for
tjzel
tomekzaw
requested changes
Oct 10, 2024
packages/react-native-reanimated/Common/cpp/reanimated/Fabric/ReanimatedCommitHook.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/Fabric/ReanimatedCommitHook.h
Outdated
Show resolved
Hide resolved
tomekzaw
approved these changes
Oct 10, 2024
packages/react-native-reanimated/Common/cpp/reanimated/Fabric/ReanimatedCommitHook.h
Outdated
Show resolved
Hide resolved
…ReanimatedCommitHook.h Co-authored-by: Tomek Zawadzki <[email protected]>
bartlomiejbloniarz
deleted the
@bartlomiejbloniarz/fix-layout-animations-initialization
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
## Summary This PR changes the way we keep track of the window dimensions in Layout Animations on the New Arch. The previous version didn't work on Android in release mode. This new approach is possible because we moved the initialization of layout animations to the commit hook in #6586. ## Test plan Check if Layout Animations dependent on `windowWidth` (e.g. SlideInLeft) work properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since RN 0.76 the first surface is created after our
initializeTurboModulemethod is called on iOS. This change is probably a result of this PR. This breaks our initialization oflayoutAnimationsProxy_, so now we lazy initialize it for every surface in the Commit hook.Test plan
Check if layout animations work in the
fabric-exampleapp.