Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reJest] Fixes problem with opacity comparation #6233

Merged
merged 2 commits into from
Jul 16, 2024
Merged

[reJest] Fixes problem with opacity comparation #6233

merged 2 commits into from
Jul 16, 2024

Conversation

piaskowyk
Copy link
Member

Summary

Due to some platform limitations, certain properties may not be exact values as originally set, for example, opacity. This PR introduces new comparators, CLOSE_DISTANCE and FLOAT, which can be used in cases where we can't achieve the exact value as originally set.

@piaskowyk piaskowyk requested a review from Latropos July 8, 2024 13:23
Latropos
Latropos approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@Latropos Latropos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! However I wish you renamed CLOSE_DISTANCE to CLOSE_NUMBER, it seems a bit more accurate

@piaskowyk
Copy link
Member Author

I named it CLOSE_DISTANCE to maintain naming conventions, as the DISTANCE mode already exists.

@piaskowyk piaskowyk added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 7f0a083 Jul 16, 2024
5 checks passed
@piaskowyk piaskowyk deleted the @piaskowyk/close-distance branch July 16, 2024 11:27
@chaitanyapotti chaitanyapotti mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 28, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Aug 28, 2024
Closed
@jaydenchee97 jaydenchee97 mentioned this pull request Aug 28, 2024
Open
@azu-josh azu-josh mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 29, 2024
Open
@Bonnie-TJ Bonnie-TJ mentioned this pull request Sep 4, 2024
Merged
@tanyipeng834 tanyipeng834 mentioned this pull request Sep 4, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 6, 2024
Closed
@mhmoudmhmed mhmoudmhmed mentioned this pull request Sep 7, 2024
Open
This was referenced Sep 7, 2024
Closed
Closed
@phucle1010 phucle1010 mentioned this pull request Sep 24, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 24, 2024
Closed
This was referenced Sep 24, 2024
Open
Open
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Sep 24, 2024
Merged
This was referenced Sep 25, 2024
Closed
Closed
Closed
@ananichoumchoum ananichoumchoum mentioned this pull request Sep 27, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 28, 2024
Closed
@yingbull yingbull mentioned this pull request Sep 28, 2024
Closed
@manh20012000 manh20012000 mentioned this pull request Sep 29, 2024
Open
@Alaa-1074002 Alaa-1074002 mentioned this pull request Sep 29, 2024
Open
@manh20012000 manh20012000 mentioned this pull request Oct 1, 2024
Open
This was referenced Oct 1, 2024
Closed
Closed
@phucle1010 phucle1010 mentioned this pull request Oct 2, 2024
Open
This was referenced Oct 3, 2024
Closed
Closed
This was referenced Oct 4, 2024
Closed
Closed
This was referenced Oct 5, 2024
Closed
Closed
@phucle1010 phucle1010 mentioned this pull request Oct 25, 2024
Open
@0xk4b1r 0xk4b1r mentioned this pull request Oct 28, 2024
Closed
@yingbull yingbull mentioned this pull request Oct 28, 2024
Closed
@phucle1010 phucle1010 mentioned this pull request Nov 1, 2024
Open
@Abyss0108 Abyss0108 mentioned this pull request Nov 3, 2024
Open
@0xk4b1r 0xk4b1r mentioned this pull request Nov 4, 2024
Closed
@PoojaPanchal12 PoojaPanchal12 mentioned this pull request Nov 5, 2024
Open
@edwardsph edwardsph mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Latropos Latropos Latropos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piaskowyk @Latropos