Fix TS and initialization order for executeUIRuntimeSync.
#5516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
commented
Dec 21, 2023
| @@ -65,10 +65,10 @@ class WorkletRuntime : public jsi::HostObject, | |||
| std::vector<jsi::PropNameID> getPropertyNames(jsi::Runtime &rt) override; | |||
|
|
|||
| private: | |||
| std::recursive_mutex runtimeMutex_; | |||
There was a problem hiding this comment.
I think this should be moved because it's used in WorkletRuntime::WorkletRuntime constructor as an argument of makeRuntime before its own std::recursive_mutex default constructor was called.
While it will probably work because we are only passing the address there, I think it's safer to have it initialized already.
There was a problem hiding this comment.
That's a good point, and you're right! Yes, it works because we are passing a pointer instead of the value of the field
piaskowyk
approved these changes
Dec 21, 2023
piaskowyk
merged commit f5c312a
into
@piaskowyk/sync-calls-on-ui-runtime
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Minor changes to #4300.
Test plan
🚀