Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused debugToken_ in release mode #3909

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

tomekzaw
Copy link
Member

@tomekzaw tomekzaw commented Jan 4, 2023

Summary

This PR fixes a warning that debugToken_ field is unused in release mode after #3745 which gets escalated to a compile error thanks to -Werror.

Test plan

Check if Example app compiles in release mode.

@tomekzaw tomekzaw requested a review from piaskowyk January 4, 2023 16:28
@tomekzaw tomekzaw changed the title Fix unused debugToken_ Fix unused debugToken_ in release mode Jan 4, 2023
@piaskowyk piaskowyk merged commit a61b46f into main Jan 5, 2023
@piaskowyk piaskowyk deleted the @tomekzaw/fix-unused-debug-token branch January 5, 2023 08:03
fluiddot pushed a commit to wordpress-mobile/react-native-reanimated that referenced this pull request Jun 5, 2023
## Summary

This PR fixes a warning that `debugToken_` field is unused in release mode after software-mansion#3745  which gets escalated to a compile error thanks to `-Werror`.

## Test plan

Check if Example app compiles in release mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants