fix: Fix android build script for support [email protected](without new architecture) #3325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
On file CMakeLists.txt:194 you should change |
3 tasks
@jsreynaud |
|
@YangJonghun You should also add |
Merged
|
Hey, thanks for your PR! I prepared another PR based on your code, available here - #3344 I will merge it to branch Reanimated2, because the current main contains Reaniamted3 |
piaskowyk
added a commit
that referenced
this pull request
Jun 30, 2022
## Description Based on PR: #3325 Credit: @YangJonghun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this PR written for RNReanimated v2 support React Native 0.69 (without new architecture) so, should be include v2.x.x
as I know v3 is currently release candidate but, this PR created for some users use reanimated v1 api with RN v0.69
(I don't know which base branch is correct, please make any branch for release 2.8.x or 2.9.0)
fixes #3317
fixes #3320
fixes #3323
fixes #3310
Changes
Test code and steps to reproduce
Checklist