Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flatlist scroll with refresh #1742

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

piaskowyk
Copy link
Member

@piaskowyk piaskowyk commented Feb 22, 2021

Description

Fixes: #1703

If FlatList contains onRefresh property then ReactScrollView is wrapped by ReactSwipeRefreshLayout who doesn't have smoothScrollTo() method.

ReactSwipeRefreshLayout support only vertical scroll - "The SwipeRefreshLayout should be used whenever the user can refresh the contents of a view via a vertical swipe gesture."

@piaskowyk piaskowyk merged commit d92b871 into master Feb 24, 2021
@piaskowyk piaskowyk deleted the @piaskowyk/fix-flatlist-scroll-with-refresh branch February 24, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android: scrollTo with FlatList breaks as soon as refresh control is added
2 participants