Skip to content

Commit

Permalink
Remove Expo adapter (#3113)
Browse files Browse the repository at this point in the history
## Description

with #3005, we don't need the expo adapter to install JSI bindings. by removing the adapter, this pr will also fix #3084 and fix #3021

## Changes

remove expo adapter

## Test code and steps to reproduce

1. `$ createNPMPackage.sh`
2. create an expo sdk44 project, `yarn add file:/path/to/react-native-reanimated-2.5.0.tgz` and test launching.
2. create an react-native 0.67 project, `yarn add file:/path/to/react-native-reanimated-2.5.0.tgz` and test launching.

## Checklist

- [ ] Included code example that can be used to test this change
- [ ] Updated TS types
- [ ] Added TS types tests
- [ ] Added unit / integration tests
- [ ] Updated documentation
- [ ] Ensured that CI passes
  • Loading branch information
Kudo authored Apr 1, 2022
1 parent b7354c8 commit 1664f48
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 102 deletions.
46 changes: 0 additions & 46 deletions android-npm/expo/linking.gradle

This file was deleted.

This file was deleted.

This file was deleted.

12 changes: 0 additions & 12 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,6 @@ def resolveBuildType() {
return true
}

def resolveExpoLinkingGradle() {
def gradleScript = file("./expo/linking.gradle")
if (gradleScript.exists()) {
return "./expo/linking.gradle"
} else {
return "../android-npm/expo/linking.gradle"
}
}

def isDeveloperMode() {
// developer mode, to run Example app
return file("$projectDir/../node_modules/react-native/package.json").exists()
Expand Down Expand Up @@ -291,9 +282,6 @@ if (!BUILD_FROM_SOURCE) {
// end if already loaded aar
if (!BUILD_FROM_SOURCE) return

// apply expo config
apply from: resolveExpoLinkingGradle()

def localProps = new Properties()
def localPropertiesFile = file("local.properties")
if (localPropertiesFile.exists()) {
Expand Down
2 changes: 0 additions & 2 deletions createNPMPackage.sh
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,10 @@ done

yarn add react-native@"${versions[0]}" --dev

cp -R android-npm/expo android/
cp -R android/build build_output
cd android && ./gradlew clean && cd ..
yarn run type:generate
npm pack
rm -rf android/expo

rm -rf ./lib
rm -rf ./android/rnVersionPatch/backup/*
Expand Down
3 changes: 0 additions & 3 deletions expo-module.config.json

This file was deleted.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
"react-native-reanimated.d.ts",
"mock.js",
"plugin.js",
"expo-module.config.json",
"!__snapshots__",
"!*.test.js",
"!*.test.js.map"
Expand Down

0 comments on commit 1664f48

Please sign in to comment.