Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ToolbarAndroid (Lean Core) #888

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Remove ToolbarAndroid (Lean Core) #888

merged 1 commit into from
Jan 2, 2020

Conversation

brunolemos
Copy link
Contributor

You can see there isn't any reference to ToolbarAndroid on react-native anymore: https://github.com/facebook/react-native/search?q=ToolbarAndroid&type=Code

It got removed on 0.61 I guess, with the Lean Core effort.

This is causing an error when using [email protected] or newer:

Failed to compile
node_modules/react-native-gesture-handler/GestureComponents.web.js
Module not found: Can't resolve 'react-native-web/dist/exports/ToolbarAndroid' in 'node_modules/react-native-gesture-handler'

@brunolemos brunolemos mentioned this pull request Dec 20, 2019
Closed
@osdnk osdnk merged commit a40804d into software-mansion:master Jan 2, 2020
janicduplessis pushed a commit to janicduplessis/react-native-gesture-handler that referenced this pull request Feb 16, 2020
@brunolemos @janicduplessis
Remove ToolbarAndroid (Lean Core) (software-mansion#888)
ea0447d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osdnk osdnk osdnk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunolemos @osdnk