Fix TouchableNativeFeedback regression
#3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-bert
reviewed
Dec 17, 2024
| console.warn( | ||
| tagMessage( | ||
| 'TouchableOpacity component will be removed in the future version of Gesture Handler.' | ||
| 'TouchableNativeFeedback component will be removed in the future version of Gesture Handler.' |
There was a problem hiding this comment.
Suggested change
| 'TouchableNativeFeedback component will be removed in the future version of Gesture Handler.' |
Let's remove this console.log as in other Touchables
|
This is what I meant when I asked if deprecation note works: 
|
fixed in 1e8e07e |
m-bert
approved these changes
Dec 19, 2024
m-bert
pushed a commit
that referenced
this pull request
Dec 20, 2024
## Description #3260 introduced a regression to the `Gesture Handlers`'s `TouchableNativeFeedback` component. The component used to be a direct reference to the `TouchableNativeFeedback`, which has a [couple of static methods](https://reactnative.dev/docs/touchablenativefeedback#methods). When it was replaced with a function component, the static methods got removed, leaving only the render function of the `TouchableNativeFeedback`. ## Test plan See how the type errors in the `example/src/release_tests/touchables/index.tsx` are resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#3260 introduced a regression to the
Gesture Handlers'sTouchableNativeFeedbackcomponent.The component used to be a direct reference to the
TouchableNativeFeedback, which has a couple of static methods.When it was replaced with a function component, the static methods got removed, leaving only the render function of the
TouchableNativeFeedback.Test plan
See how the type errors in the
example/src/release_tests/touchables/index.tsxare resolved.