Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer accessibility label from children in RNGestureHandlerButton on iOS #3290

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Infer accessibility label from children in RNGestureHandlerButton on iOS #3290

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7380326
Infer accessibility label from children in RNGestureHandlerButton on iOS
oblador Dec 16, 2024
827214d
Use RNGHUIView over UIView
oblador Dec 16, 2024
6635253
Exclude macOS...
oblador Dec 16, 2024
56ff65d
Add AccessibilityProps to RawButton
oblador Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions apple/RNGestureHandlerButton.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,34 @@ - (void)displayLayer:(CALayer *)layer
const CGFloat currentBorderRadius = radius * scaleFactor;
layer.cornerRadius = currentBorderRadius;
}

- (NSString *)accessibilityLabel
{
NSString *label = super.accessibilityLabel;
if (label) {
return label;
}
return RNGHRecursiveAccessibilityLabel(self);
}

// Vendored from RCTView.m to infer accessibility label from children
static NSString *RNGHRecursiveAccessibilityLabel(UIView *view)
{
NSMutableString *str = [NSMutableString stringWithString:@""];
for (UIView *subview in view.subviews) {
NSString *label = subview.accessibilityLabel;
if (!label) {
label = RNGHRecursiveAccessibilityLabel(subview);
}
if (label && label.length > 0) {
if (str.length > 0) {
[str appendString:@" "];
}
[str appendString:label];
}
}
return str.length == 0 ? nil : str;
}
#endif

#if TARGET_OS_OSX && RCT_NEW_ARCH_ENABLED
Expand Down
Loading