Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web] Migrate to get and set #3263

Merged
merged 7 commits into from
Dec 16, 2024
Merged

[Web] Migrate to get and set #3263

merged 7 commits into from
Dec 16, 2024

Conversation

m-bert
Copy link
Contributor

@m-bert m-bert commented Dec 6, 2024

Description

In this PR I've migrated our handlers into get/set functions instead of traditional getters and setters convention (like in Java).

Test plan

Run web example

@m-bert m-bert mentioned this pull request Dec 6, 2024
Closed
@m-bert m-bert marked this pull request as ready for review December 6, 2024 14:50
@m-bert m-bert requested review from latekvo and j-piasecki and removed request for latekvo December 6, 2024 14:50
@m-bert m-bert requested a review from j-piasecki December 9, 2024 08:49
@m-bert m-bert requested a review from j-piasecki December 16, 2024 09:10
j-piasecki
j-piasecki approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@j-piasecki j-piasecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure about @latekvo

@m-bert
Copy link
Contributor Author

m-bert commented Dec 16, 2024

LGTM, not sure about @latekvo

I'll wait for his approval 😅

latekvo
latekvo approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@latekvo latekvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit-pick

src/web/detectors/ScaleGestureDetector.ts Show resolved Hide resolved
@m-bert m-bert merged commit 5752e01 into next Dec 16, 2024
1 check passed
@m-bert m-bert deleted the @mbert/get-set branch December 16, 2024 16:34
m-bert added a commit that referenced this pull request Dec 20, 2024
@m-bert
[Web] Migrate to get and set (#3263)
8f34660 
In this PR I've migrated our handlers into `get`/`set` functions instead of traditional getters and setters convention (like in `Java`).

Run web example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@latekvo latekvo latekvo approved these changes

@j-piasecki j-piasecki j-piasecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-bert @j-piasecki @latekvo