Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize dependency list #3216

Merged
merged 16 commits into from
Nov 21, 2024
Merged

Optimize dependency list #3216

merged 16 commits into from
Nov 21, 2024

Conversation

latekvo
Copy link
Contributor

@latekvo latekvo commented Nov 15, 2024

Description

  • removes unnecessary expo package
  • removes unnecessary prop-types package
  • removes unused react-dom library
  • removes multiple unused @babel packages
  • removes multiple unused testing packages`

Test plan

  • open example app, see how everything works and no errors are thrown
    • test common example (ios, web, android)
    • test MacOS example
    • test Fabric example (ios, android)
  • build package, use rngh from this PR in a fresh react native app
    • test on web
    • test on android
    • test on iOS

@latekvo latekvo changed the title Add missing packages to the peer dependencies and remove unnecessary packages from dev dependencies Fix library dependency lists Nov 15, 2024
@latekvo latekvo changed the title Fix library dependency lists Fix dependency list, add missing dependencies, remove unnecessary ones Nov 15, 2024
@latekvo latekvo changed the title Fix dependency list, add missing dependencies, remove unnecessary ones Optimize dependency list Nov 15, 2024
@latekvo latekvo requested review from j-piasecki and m-bert November 19, 2024 15:31
@latekvo latekvo marked this pull request as ready for review November 19, 2024 15:32
Copy link
Member

@j-piasecki j-piasecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the js tests still pass?

package.json Outdated
Comment on lines 105 to 106
"react-native": ">= 0.73.0",
"react-native-reanimated": ">= 2.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't change that - we don't want to have any dependencies on Reanimated (if someone tries to use RNGH with Reanimated 1 it's fine, they just won't integrate). And we don't want to set the lower bound on RN version either - if a new version of RNGH works with the old version of RN it's fine, we just don't guarantee it.

This comment was marked as resolved.

Copy link
Contributor Author

@latekvo latekvo Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, after looking at the documentation some more, i think you're right.
I'll keep the React Native version at *, and remove Reanimated from it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted in 04b1159

@latekvo
Copy link
Contributor Author

latekvo commented Nov 20, 2024

Do the js tests still pass?

Yes, ts-check passes, lint:js-root passes, lint:js has the same issues that occur on the main branch.

@j-piasecki
Copy link
Member

I meant yarn test

@latekvo
Copy link
Contributor Author

latekvo commented Nov 20, 2024

yarn test passes as well

image

@latekvo latekvo merged commit 3daca2d into main Nov 21, 2024
3 checks passed
@latekvo latekvo deleted the @latekvo/increase-peer-deps-usage branch November 21, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants