-
-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize dependency list #3216
Optimize dependency list #3216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the js tests still pass?
package.json
Outdated
"react-native": ">= 0.73.0", | ||
"react-native-reanimated": ">= 2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't change that - we don't want to have any dependencies on Reanimated (if someone tries to use RNGH with Reanimated 1 it's fine, they just won't integrate). And we don't want to set the lower bound on RN version either - if a new version of RNGH works with the old version of RN it's fine, we just don't guarantee it.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, after looking at the documentation some more, i think you're right.
I'll keep the React Native
version at *
, and remove Reanimated
from it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted in 04b1159
Yes, |
I meant |
Description
expo
packageprop-types
packagereact-dom
library@babel
packagesTest plan
rngh
from thisPR
in a fresh react native app