-
-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ReanimatedDrawerLayout
component
#3146
Conversation
…shared values into shared values, reduce amount of shared values used
…tions to UI thread
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please wait for GH actions before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things that I've noticed:
- Drawer sometimes flickers (i.e. closes and immediately opens). Unfortunately I'm not exactly sure how to reproduce it.
- In the provided example, when
drawer
is opened onweb
it is possible to click buttons in background. It doesn't work like this onandroid
andiOS
but I think we don't have to worry about it in this PR as it is already quite large 😅
## Description This PR adds documentation page for the new `ReanimatedDrawerLayout` component. wait for #3146 ## Test plan - open the documentation page for `ReanimatedDrawerLayout`
## Description Bump prettier version to 3.3.3. Required for [this](#3146 (comment)) issue to be resolved. ## Test plan - confirm all CIs are passing - confirm none of the examples are crashing
Description
This PR adds
ReanimatedDrawerLayout
component.Test plan
Collapsed code - legacy component preview