Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant example entry in App.tsx #3138

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Remove redundant example entry in App.tsx #3138

merged 2 commits into from
Oct 4, 2024

Conversation

latekvo
Copy link
Contributor

@latekvo latekvo commented Oct 4, 2024

Description

There are 2 Pressable entries, likely as a result of merge conflicts which occurred between these two PRs:

Update examples and Make osx example utilise the common example app

@latekvo latekvo marked this pull request as ready for review October 4, 2024 13:52
@latekvo latekvo requested a review from m-bert October 4, 2024 13:52
m-bert
m-bert reviewed Oct 4, 2024
View reviewed changes
Copy link
Contributor

@m-bert m-bert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we keep it as Pressable? I agree that it's new, but we haven't had that before 😅

@latekvo latekvo requested a review from m-bert October 4, 2024 14:30
@latekvo latekvo merged commit 77c5f37 into main Oct 4, 2024
2 checks passed
@latekvo latekvo deleted the @latekvo/remove-redundant-pressable-example branch October 4, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-bert m-bert m-bert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@latekvo @m-bert