[Web] Stylus support #3107
Merged
[Web] Stylus support #3107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-bert
requested review from
latekvo and
j-piasecki
and removed request for
latekvo
j-piasecki
reviewed
Sep 19, 2024
src/web/tools/PointerEventManager.ts
Outdated
Comment on lines
85
to
87
| // Stylus triggers `pointermove` event when it detects changes in pressure. Since it is very sensitive to those changes, | ||
| // it constantly sends events, even though there was no change in position. To fix that we check whether | ||
| // pointer has actually moved and if not, we do not send event. |
There was a problem hiding this comment.
Good catch! Removed in f98b911
src/web/utils.ts
Outdated
| // or that none of the position sets is supported. In that case, we can treat stylus as perpendicular | ||
| // | ||
| // @ts-ignore This property exists (https://developer.mozilla.org/en-US/docs/Web/API/PointerEvent#instance_properties) | ||
| if (event.azimuthAngle === undefined || event.altitudeAngle === undefined) { |
There was a problem hiding this comment.
You can extract those to variables instead of @ts-ignoring multiple times
There was a problem hiding this comment.
Good idea. Done in 9fa4003
j-piasecki
approved these changes
Sep 19, 2024
Merged
m-bert
added a commit
that referenced
this pull request
Sep 24, 2024
## Description This PR adds stylus support on Android. >[!NOTE] > You can read more about this feature in #3107 ## Test plan Tested on **_StylusData_** example
m-bert
added a commit
that referenced
this pull request
Sep 24, 2024
## Description This PR adds stylus support on `iOS`. >[!WARNING] > This PR lacks support for `Hover` since currently we are unable to test that. >[!NOTE] > You can read more about this feature in #3107 ## Test plan Tested on **_StylusData_** example
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds more information about
stylusto event.PanandHoverevents now havestylusDatafield, which contains the following information:tiltXtiltYaltitudeAngleazimuthAnglepressureImportant
Because we receive only one set of data (either
tiltX/tiltYoraltitudeAngle/azimuthAngle, we use this conversion algorithm to calculate second set.Note
This PR adds
stylusDataonly on web, native platforms will be handled in another PRsTest plan
Tested on newly added example.