Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples #2919

Merged
merged 25 commits into from
Sep 26, 2024
Merged

Update examples #2919

merged 25 commits into from
Sep 26, 2024

Conversation

j-piasecki
Copy link
Member

@j-piasecki j-piasecki commented May 17, 2024 •
edited
Loading

Description

  • moves New Api section to the top
  • unifies white-ish backgrounds across examples
  • unifies Velocity Test with Simple Reanimated example
  • unifies Overlap Parent and OverlapSiblings
  • updates Transformations
  • updates Camera since the camera was missing there
  • updates Pan Responder to not use setNativeProps which was removed on RN web

Test plan

Check the updated examples

@j-piasecki j-piasecki marked this pull request as ready for review May 28, 2024 17:00
@j-piasecki j-piasecki requested a review from m-bert May 28, 2024 17:00
m-bert
m-bert requested changes May 29, 2024
View reviewed changes
Copy link
Contributor

@m-bert m-bert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I really like new look of our app ❤️

I've left some suggestions, let me know what do you think about them.

Also there's one problem - transformations example no longer works on web. Could you please check that?

example/App.tsx Outdated Show resolved Hide resolved
example/src/new_api/velocityTest/index.tsx Outdated Show resolved Hide resolved
example/src/new_api/camera/AnimatedCameraView.tsx Show resolved Hide resolved
example/src/ListWithHeader/Header.tsx Outdated Show resolved Hide resolved
@m-bert
Copy link
Contributor

m-bert commented May 29, 2024 •
edited
Loading

Also, one more detail

  • updates Pan Responder to not use setNativeProps which was removed on RN web

I think that combo example still uses setNativeProps. Do we plan to remove that?

@j-piasecki
Copy link
Member Author

j-piasecki commented May 29, 2024 •
edited
Loading

Most likely yes.

Update: removed in 156c3bc

@j-piasecki
Copy link
Member Author

Also there's one problem - transformations example no longer works on web. Could you please check that?

It seems like passing the matrix as transform directly didn't work on web. Now it applies styles, but they are not right. It looks like on web focal and anchor points (for pinch and rotation gestures respectively) aren't in the coordinate space of the view like on Android and iOS. Could you check that? And should I open an issue for this or do you want to?

@m-bert
Copy link
Contributor

m-bert commented Jun 3, 2024

And should I open an issue for this or do you want to?

You can open an issue. I will look into it later 😅

@m-bert m-bert mentioned this pull request Aug 21, 2024
Merged
@j-piasecki j-piasecki mentioned this pull request Sep 25, 2024
Open
@j-piasecki j-piasecki requested a review from m-bert September 25, 2024 07:34
@j-piasecki
Copy link
Member Author

I've moved the complex transform logic to the separate PR so this stops being blocked by wrong anchor/focal points on web - #3124

m-bert
m-bert reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@m-bert m-bert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved the complex transform logic to the separate PR so this stops being blocked by wrong anchor/focal points on web - #3124

So I think we can remove matrices from description:

updates Transformations to use matrices and update the look

example/app.json Outdated Show resolved Hide resolved
@j-piasecki j-piasecki merged commit 15c1156 into main Sep 26, 2024
2 checks passed
@j-piasecki j-piasecki deleted the @jpiasecki/update-examples branch September 26, 2024 11:23
latekvo added a commit that referenced this pull request Nov 13, 2024
@latekvo
update ball example link, link invalid since PR #2919
472c6ce
@latekvo latekvo mentioned this pull request Nov 13, 2024
Merged
latekvo added a commit that referenced this pull request Nov 18, 2024
@latekvo
Fix broken links in the quickstart docs page (#3213)
f58afd2 
## Description

Fix broken links in the `quickstart` docs page.

- replace the `SharedValue` description link
- replace the `ballTest` code link broken in #2919

## Test plan

- open the old links
- open the new links
- see how the old links are broken
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-bert m-bert m-bert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-piasecki @m-bert @latekvo