Fix no multiple installations assertion on Android #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 18, 2022
kkafar
force-pushed
the
@kkafar/fix-build-gradle
branch
from
eb02b18 to
044208c
Compare
j-piasecki
approved these changes
Aug 25, 2022
piaskowyk
pushed a commit
to software-mansion/react-native-reanimated
that referenced
this pull request
Sep 9, 2022
) ## Description See: software-mansion/react-native-gesture-handler#2174 ## Changes Fixed crashing on symlinks with filtering files before executing operations on them, added property `disableMultipleInstancesCheck ` (possible to specify in `gradle.properties` of **rootProject**) which allow application to disable the feature. Note that this property is shared with `react-native-gesture-handler` - so if someone sets `disableMultipleInstancesCheck=true` the assertion won't run for neither `react-native-reanimated` nor `react-native-gesture-handler`. ## Test code and steps to reproduce Works fine on `TestsExample` application in `react-native-screens` repository. ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Added TS types tests - [ ] Added unit / integration tests - [ ] Updated documentation - [ ] Ensured that CI passes Co-authored-by: Jakub Piasecki <[email protected]>
piaskowyk
pushed a commit
to software-mansion/react-native-reanimated
that referenced
this pull request
Oct 6, 2022
) See: software-mansion/react-native-gesture-handler#2174 Fixed crashing on symlinks with filtering files before executing operations on them, added property `disableMultipleInstancesCheck ` (possible to specify in `gradle.properties` of **rootProject**) which allow application to disable the feature. Note that this property is shared with `react-native-gesture-handler` - so if someone sets `disableMultipleInstancesCheck=true` the assertion won't run for neither `react-native-reanimated` nor `react-native-gesture-handler`. Works fine on `TestsExample` application in `react-native-screens` repository. - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Added TS types tests - [ ] Added unit / integration tests - [ ] Updated documentation - [ ] Ensured that CI passes Co-authored-by: Jakub Piasecki <[email protected]>
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
…ftware-mansion#3493) ## Description See: software-mansion/react-native-gesture-handler#2174 ## Changes Fixed crashing on symlinks with filtering files before executing operations on them, added property `disableMultipleInstancesCheck ` (possible to specify in `gradle.properties` of **rootProject**) which allow application to disable the feature. Note that this property is shared with `react-native-gesture-handler` - so if someone sets `disableMultipleInstancesCheck=true` the assertion won't run for neither `react-native-reanimated` nor `react-native-gesture-handler`. ## Test code and steps to reproduce Works fine on `TestsExample` application in `react-native-screens` repository. ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Added TS types tests - [ ] Added unit / integration tests - [ ] Updated documentation - [ ] Ensured that CI passes Co-authored-by: Jakub Piasecki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous implementation had flaws:
react-native-gesture-handlerdirectories inside dependencies. ConsiderFabricTestExampleinreact-native-screens. In itspackage.jsonit hasreact-native-screensdefined aslink:../-> following error occurs:This PR resolves both issues:
package.jsonto not be a symlink)assertNoMultipleInstallationsproperty ingradle.propertiesof root project.Note that this property is shared with
react-native-reanimated- so if someone setsdisableMultipleInstancesCheck=truethe assertion won't run for neitherreact-native-reanimatednorreact-native-gesture-handler.Test plan