-
-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit hook and linters for Android and iOS code #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments. Overall LGTM 👍
Co-authored-by: Kacper Kapuściak <[email protected]>
kacperkapusciak
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
.gitignore
,build.gradle
andproguard-rules.pro
files from thelib/
directory. I believe those were leftovers from when Gesture Handler could be used as a native Android libraryandroid/
directory.clang-format
for linting the iOS code, the config is the same as in Screens and ReanimatedspotlessCheck
While this PR formats Android code, it doesn't modify the iOS one. On Android there weren't that many changes and the number of affected files was low. On iOS there are more changes needed in more files. The idea behind that is that the changed files from now on will have to be reformatted, so the style changes will be more gradual without one huge commit changing the whole codebase. After some time we could make one commit that updates the remaining files, which should result in a clearer history.
Also, at some point in the future we should think about updating the
prettier
version the root project is using to match the one in example apps, although it would require reformatting the code. This would allow for handling core, Example and FabricExample code using the samelint-staged
rule, instead of each one of those having their own.