Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RN headers in both namespaces on iOS #1183

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

geraintwhite
Copy link
Contributor

Fixes #816

Support RN headers both in the React namespace and no namespace, for older versions of RN.

Fixes #816 

Support RN headers both in the React namespace and no namespace, for older versions of RN.
@carloscuesta
Copy link

Hey @jakub-gonet can you take a look at this? 🙏🏼

Thanks ❤️

@jakub-gonet
Copy link
Member

LGTM, thanks!

@jakub-gonet jakub-gonet changed the title Add support for RN headers in both namespaces Support RN headers in both namespaces on iOS Sep 30, 2020
@jakub-gonet jakub-gonet merged commit 0f96ac3 into software-mansion:master Sep 30, 2020
@geraintwhite geraintwhite deleted the patch-1 branch September 30, 2020 13:33
braincore pushed a commit to braincore/react-native-gesture-handler that referenced this pull request Mar 4, 2021
Fixes software-mansion#816 

Support RN headers both in the React namespace and no namespace, for older versions of RN.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.5.0 iOS build fails with RN 0.59
3 participants