Pan gesture always runs simultaneously with the PagerView #2870
Labels
Comments
j-piasecki
added a commit
that referenced
this issue
May 9, 2024
## Description Gesture Handler is handling calls to `requestDisallowInterceptTouchEvent` by canceling all gestures: https://github.com/software-mansion/react-native-gesture-handler/blob/5523506c7b64ac5a8a78f5d73dc96adfb13962ba/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerRootHelper.kt#L90-L94 This is done by activating a root handler that should, in turn, cancel other gestures: https://github.com/software-mansion/react-native-gesture-handler/blob/5523506c7b64ac5a8a78f5d73dc96adfb13962ba/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerRootHelper.kt#L109-L114 There is a case where this doesn't currently work: when gesture A waits for gesture B and root view is activated, gesture B gets canceled but gesture A is not due to this check: https://github.com/software-mansion/react-native-gesture-handler/blob/5523506c7b64ac5a8a78f5d73dc96adfb13962ba/android/src/main/java/com/swmansion/gesturehandler/core/GestureHandlerOrchestrator.kt#L692-L698 Since handler A is awaiting, it doesn't get canceled. Gesture B does get canceled, which in turn causes gesture A to activate, effectively making it ignore the cancellation. This happens because of this method: https://github.com/software-mansion/react-native-gesture-handler/blob/5523506c7b64ac5a8a78f5d73dc96adfb13962ba/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerInteractionManager.kt#L52-L58 which will always return false if the activating gesture is root view. This PR makes it so that if the activating gesture is the root handler, `shouldHandlerBeCancelledBy` will always return `true`, canceling the waiting gesture. Fixes #2870 ## Test plan Tested on the example app and the reproducer from the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
It looks like the pan gesture is not canceled when the
RootViewGestureHandleractivates, because it's already in the active state. I'm not sure whether it should be active at this point, or should be canceled despite being active.Steps to reproduce
Snack or a link to a repository
https://github.com/lukmccall/ghandpager
Gesture Handler version
2.16.0
React Native version
0.73.6
Platforms
Android
JavaScript runtime
Hermes
Workflow
Expo bare workflow
Architecture
Paper (Old Architecture)
Build type
Debug mode
Device
Android emulator
Device model
No response
Acknowledgements
Yes
The text was updated successfully, but these errors were encountered: