Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lodash #2613

Closed
jthoward64 opened this issue Sep 28, 2023 · 1 comment · Fixed by #2916
Closed

Remove lodash #2613

jthoward64 opened this issue Sep 28, 2023 · 1 comment · Fixed by #2916
Labels
Missing repro Platform: Web

Comments

@jthoward64
Copy link

jthoward64 commented Sep 28, 2023 •
edited
Loading

Description

As far as I can tell lodash is used once anywhere in the repo and could either be replaced with lodash.isEqual or native JS.

Steps to reproduce

N/A

Snack or a link to a repository

https://github.com/software-mansion/react-native-gesture-handler/blob/a9272cf2471bd869a3c81e13fa114ecfea3cc835/src/handlers/createHandler.tsx#L391C13-L391C14

Gesture Handler version

2.13.1

React Native version

N/A

Platforms

Web

JavaScript runtime

None

Workflow

None

Architecture

None

Build type

None

Device

None

Device model

No response

Acknowledgements

Yes
@github-actions
Copy link

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

@m-bert m-bert mentioned this issue May 17, 2024
Merged
m-bert added a commit that referenced this issue May 17, 2024
@m-bert @j-piasecki
Remove lodash (#2916)
00dcb64 
## Description

Since `lodash` is used only in one place in our codebase, we can simply replace it with our own implementation on `deepEqual`.

Closes #2613 

## Test plan

Run example apps.
---------

Co-authored-by: Jakub Piasecki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Missing repro Platform: Web
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove lodash software-mansion/react-native-gesture-handler
1 participant
@jthoward64