Skip to content

Commit

Permalink
Fix transform on GestureHandlerButton on Android (#3252)
Browse files Browse the repository at this point in the history
## Description

RN now handles view transform in onAfterUpdateTransaction
https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java#L634
so we need to make sure to call the super method.

## Test plan

Tested that setting transform on button component now works on Android.
  • Loading branch information
janicduplessis authored Dec 20, 2024
1 parent a5cb68c commit 82c4e4a
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,8 @@ class RNGestureHandlerButtonViewManager : ViewGroupManager<ButtonViewGroup>(), R
}

override fun onAfterUpdateTransaction(view: ButtonViewGroup) {
super.onAfterUpdateTransaction(view)

view.updateBackground()
}

Expand Down

0 comments on commit 82c4e4a

Please sign in to comment.