feat(core): add break unit lint

crates/cairo-lint-core/src/fix.rs

@@ -142,12 +142,17 @@ impl Fixer {
                 self.fix_double_parens(db.upcast(), plugin_diag.stable_ptr.lookup(db.upcast()))
             }
             CairoLintKind::DestructMatch => self.fix_destruct_match(db, plugin_diag.stable_ptr.lookup(db.upcast())),
+            CairoLintKind::BreakUnit => self.fix_break_unit(db, plugin_diag.stable_ptr.lookup(db.upcast())),
             _ => return None,
         };
 
         Some((semantic_diag.stable_location.syntax_node(db.upcast()), new_text))
     }
 
+    pub fn fix_break_unit(&self, db: &dyn SyntaxGroup, node: SyntaxNode) -> String {
+        node.get_text(db).replace("break ();", "break;").to_string()
+    }
+
     /// Removes unnecessary double parentheses from a syntax node.
     ///
     /// Simplifies an expression by stripping extra layers of parentheses while preserving

crates/cairo-lint-core/src/lints/breaks.rs

@@ -0,0 +1,16 @@
+use cairo_lang_defs::plugin::PluginDiagnostic;
+use cairo_lang_diagnostics::Severity;
+use cairo_lang_syntax::node::db::SyntaxGroup;
+use cairo_lang_syntax::node::SyntaxNode;
+
+pub const BREAK_UNIT: &str = "unnecessary double parentheses found after break. Consider removing them.";
+
+pub fn check_break(db: &dyn SyntaxGroup, node: SyntaxNode, diagnostics: &mut Vec<PluginDiagnostic>) {
+    if node.clone().get_text_without_trivia(db).ends_with("();") {
+        diagnostics.push(PluginDiagnostic {
+            stable_ptr: node.stable_ptr(),
+            message: BREAK_UNIT.to_string(),
+            severity: Severity::Warning,
+        });
+    }
+}

crates/cairo-lint-core/src/lints/mod.rs

@@ -1,3 +1,4 @@
+pub mod breaks;
 pub mod double_parens;
 pub mod loops;
 pub mod single_match;

crates/cairo-lint-core/src/plugin.rs

@@ -7,7 +7,7 @@ use cairo_lang_syntax::node::ast::Expr as AstExpr;
 use cairo_lang_syntax::node::kind::SyntaxKind;
 use cairo_lang_syntax::node::{TypedStablePtr, TypedSyntaxNode};
 
-use crate::lints::{double_parens, loops, single_match};
+use crate::lints::{breaks, double_parens, loops, single_match};
 
 pub fn cairo_lint_plugin_suite() -> PluginSuite {
     let mut suite = PluginSuite::default();
@@ -23,13 +23,15 @@ pub enum CairoLintKind {
     MatchForEquality,
     DoubleParens,
     Unknown,
+    BreakUnit,
 }
 
 pub fn diagnostic_kind_from_message(message: &str) -> CairoLintKind {
     match message {
         single_match::DESTRUCT_MATCH => CairoLintKind::DestructMatch,
         single_match::MATCH_FOR_EQUALITY => CairoLintKind::MatchForEquality,
         double_parens::DOUBLE_PARENS => CairoLintKind::DoubleParens,
+        breaks::BREAK_UNIT => CairoLintKind::BreakUnit,
         _ => CairoLintKind::Unknown,
     }
 }
@@ -79,6 +81,7 @@ impl AnalyzerPlugin for CairoLint {
                         &AstExpr::from_syntax_node(db.upcast(), node),
                         &mut diags,
                     ),
+                    SyntaxKind::StatementBreak => breaks::check_break(db.upcast(), node, &mut diags),
                     _ => continue,
                 }
             }

crates/cairo-lint-core/tests/test_files/breaks/breaks

@@ -0,0 +1,95 @@
+//! > Break inside of if
+
+//! > cairo_code
+fn main() {
+    let mut a = 1_u32;
+    loop {
+        if a == 10 {
+            break ();
+        }
+        a += 1;
+    }
+}
+
+//! > diagnostics
+warning: Plugin diagnostic: unnecessary double parentheses found after break. Consider removing them.
+ --> lib.cairo:8:13
+  |
+8 |             break ();
+  |             ---------
+  |
+
+//! > fixed
+fn main() {
+    let mut a = 1_u32;
+    loop {
+        if a == 10 {
+            break;
+        }
+        a += 1;
+    }
+}
+
+//! > ==========================================================================
+
+//! > Break inside of if with comment
+
+//! > cairo_code
+fn main() {
+    let mut a = 1_u32;
+    loop {
+        if a == 10 {
+            // this is a break
+            break ();
+            // this was a break
+        }
+        a += 1;
+    }
+}
+
+//! > diagnostics
+warning: Plugin diagnostic: unnecessary double parentheses found after break. Consider removing them.
+  --> lib.cairo:10:13
+   |
+10 |             break ();
+   |             ---------
+   |
+
+//! > fixed
+fn main() {
+    let mut a = 1_u32;
+    loop {
+        if a == 10 {
+            // this is a break
+            break;
+            // this was a break
+        }
+        a += 1;
+    }
+}
+
+//! > ==========================================================================
+
+//! > Simple break
+
+//! > cairo_code
+fn main() {
+   loop {
+       break ();
+   }
+}
+
+//! > diagnostics
+warning: Plugin diagnostic: unnecessary double parentheses found after break. Consider removing them.
+ --> lib.cairo:4:8
+  |
+4 |        break ();
+  |        ---------
+  |
+
+//! > fixed
+fn main() {
+   loop {
+       break;
+   }
+}

crates/cairo-lint-core/tests/tests.rs

@@ -71,3 +71,5 @@ test_file!(
     "double parens in match arm"
 );
 test_file!(loops, loop_match_pop_front, "simple loop match pop front");
+
+test_file!(breaks, breaks, "Simple break", "Break inside of if", "Break inside of if with comment");