feat(core): add break unit lint

crates/cairo-lint-core/src/fix.rs

@@ -146,12 +146,18 @@ impl Fixer {
                 self.fix_double_parens(db.upcast(), plugin_diag.stable_ptr.lookup(db.upcast()))
             }
             CairoLintKind::DestructMatch => self.fix_destruct_match(db, plugin_diag.stable_ptr.lookup(db.upcast())),
+            CairoLintKind::BreakUnit => self.fix_break_unit(db, plugin_diag.stable_ptr.lookup(db.upcast())),
+
             _ => "".to_owned(),
         };
 
         Some((semantic_diag.stable_location.syntax_node(db.upcast()), new_text))
     }
 
+    pub fn fix_break_unit(&self, db: &dyn SyntaxGroup, node: SyntaxNode) -> String {
+        node.get_text(db).replace(" ()", "").to_string()
+    }
+
     /// Removes unnecessary double parentheses from a syntax node.
     ///
     /// Simplifies an expression by stripping extra layers of parentheses while preserving

crates/cairo-lint-core/src/lints/breaks.rs

@@ -0,0 +1,16 @@
+use cairo_lang_defs::plugin::PluginDiagnostic;
+use cairo_lang_diagnostics::Severity;
+use cairo_lang_syntax::node::db::SyntaxGroup;
+use cairo_lang_syntax::node::SyntaxNode;
+
+pub const BREAK_UNIT: &str = "unnecessary double parentheses found after break. Consider removing them.";
+
+pub fn check_break(db: &dyn SyntaxGroup, node: SyntaxNode, diagnostics: &mut Vec<PluginDiagnostic>) {
+    if node.clone().get_text_without_trivia(db).ends_with("();") {
+        diagnostics.push(PluginDiagnostic {
+            stable_ptr: node.stable_ptr(),
+            message: BREAK_UNIT.to_string(),
+            severity: Severity::Warning,
+        });
+    }
+}

crates/cairo-lint-core/src/lints/mod.rs

@@ -1,2 +1,3 @@
+pub mod breaks;
 pub mod double_parens;
 pub mod single_match;

crates/cairo-lint-core/src/plugin.rs

@@ -6,7 +6,7 @@ use cairo_lang_syntax::node::ast::{Expr, ExprMatch};
 use cairo_lang_syntax::node::kind::SyntaxKind;
 use cairo_lang_syntax::node::TypedSyntaxNode;
 
-use crate::lints::{double_parens, single_match};
+use crate::lints::{breaks, double_parens, single_match};
 
 pub fn cairo_lint_plugin_suite() -> PluginSuite {
     let mut suite = PluginSuite::default();
@@ -22,13 +22,15 @@ pub enum CairoLintKind {
     MatchForEquality,
     DoubleParens,
     Unknown,
+    BreakUnit,
 }
 
 pub fn diagnostic_kind_from_message(message: &str) -> CairoLintKind {
     match message {
         single_match::DESTRUCT_MATCH => CairoLintKind::DestructMatch,
         single_match::MATCH_FOR_EQUALITY => CairoLintKind::MatchForEquality,
         double_parens::DOUBLE_PARENS => CairoLintKind::DoubleParens,
+        breaks::BREAK_UNIT => CairoLintKind::BreakUnit,
         _ => CairoLintKind::Unknown,
     }
 }
@@ -59,6 +61,7 @@ impl AnalyzerPlugin for CairoLint {
                                 &mut diags,
                             ),
                             SyntaxKind::ItemExternFunction => (),
+                            SyntaxKind::StatementBreak => breaks::check_break(db.upcast(), descendant, &mut diags),
                             _ => (),
                         }
                     }

crates/cairo-lint-core/tests/test_files/breaks/breaks

@@ -0,0 +1,21 @@
+//! > Simple break
+
+//! > cairo_code
+fn main() {
+    loop {
+        break ();
+    }
+}
+
+//! > diagnostics
+warning: Plugin diagnostic: unnecessary double parentheses found after break. Consider removing them.
+ --> lib.cairo:3:9
+        break ();
+        ^*******^
+
+//! > fixed
+fn main() {
+    loop {
+        break;
+    }
+}

crates/cairo-lint-core/tests/tests.rs

@@ -65,3 +65,5 @@ test_file!(
     "double parens in struct field access",
     "double parens in match arm"
 );
+
+test_file!(breaks, breaks, "Simple break");