Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeSandbox CI config #581

Merged
merged 9 commits into from
Nov 26, 2024
Merged

CodeSandbox CI config #581

merged 9 commits into from
Nov 26, 2024

Conversation

mhawryluk
Copy link
Collaborator

@mhawryluk mhawryluk commented Nov 26, 2024

closes #570

Copy link

codesandbox-ci bot commented Nov 26, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@mhawryluk mhawryluk requested a review from iwoplaza November 26, 2024 10:43
@mhawryluk mhawryluk marked this pull request as ready for review November 26, 2024 10:43
Copy link
Collaborator

@iwoplaza iwoplaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🚀

@@ -1,6 +1,6 @@
{
"name": "typegpu",
"private": true,
"private": false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this prohibit the package from being built?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not from being built, but from being published yes. maybe changing this field in dist only would work. does it bother us that it's public though?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, we do set it to false in dist. I think it's therefore not necessary, but imma test it rn

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works 🎉

package.json Outdated Show resolved Hide resolved
@mhawryluk mhawryluk merged commit 47a72b8 into main Nov 26, 2024
5 checks passed
@mhawryluk mhawryluk deleted the chore/codesandbox-ci branch November 26, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly experimental build on CI for every commit on main.
2 participants