Update container.rs #282
Merged
Update container.rs #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasbeyer
requested changes
Jun 17, 2021
|
@softprops done |
matthiasbeyer
requested changes
Jun 21, 2021
|
Okay I've messed it up even more. Let me try this again 😅 |
|
Fingers crossed this time it's fine 🤞 |
|
Yay, thank you very much for your contribution! I hope you come back to contribute more! ❤️ |
|
I'd love to! I wanted to take up #291 sometime and see if I can implement that. Any pointers on how to make it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Added name filter to list containers
How did you verify your change:
Ran it on my system, but shouldn't be too big of a change to not work on any other machine.
What (if anything) would need to be called out in the CHANGELOG for the next release:
We can now filter containers by the name of the container.
PS
Would appreciate releasing this in a new release. We kinda need to use this for an application that we're using.