Fix entrypoint field in ContainerOptions
#269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elihunter173
approved these changes
Feb 11, 2021
10 tasks
|
Can a release including this change be made please? UPD: this doesn't seem to be in master anymore too... |
|
This crate is rather unmaintained I'd suggest looking for an alternative. I have an active fork with a few changes, shameless plug: https://github.com/vv9k/docker-api-rs You can also checkout bollard: https://github.com/fussybeaver/bollard |
|
Oh, thanks for the heads up, I'll look into them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Fixed
ContainerOptionsBuilder::entrypointto correctly take in an array of strings.Closes: #268
How did you verify your change:
Verified on local setup.
What (if anything) would need to be called out in the CHANGELOG for the next release:
ContainerOptionsBuilder::entrypointnow takes anIntoIterator<Item = AsRef<str>>instead of&strasentrypointparameter.