Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix X-Registry-Auth header #245

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Fix X-Registry-Auth header #245

merged 1 commit into from
Jan 13, 2021

Conversation

valff
Copy link
Contributor

@valff valff commented Jan 12, 2021

Current implementation of RegistryAuth doesn't work, because it should be encoded in url_safe base64 variant.

Relevant docs: https://docs.docker.com/engine/api/v1.41/#section/Authentication

Copy link
Owner

@softprops softprops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've catch!

@softprops
Copy link
Owner

*nice

@softprops softprops merged commit ce4e36a into softprops:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants