Add support for unit-variant enums #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobz1000
changed the title
softprops
approved these changes
Jan 5, 2020
|
published new version with this change https://github.com/softprops/envy/blob/master/CHANGELOG.md#041 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Support for unit-variant enums as values, without need for
field_identifieroruntaggedattributes. Most importantly, this allows enums with a remote Deserialize impl to be used without additional effort.Relevant issue (currently closed): #39
How did you verify your change:
Removed usage of
field_identifier&untaggedattributes in unit tests. The modified tests failed without this implementation, and now pass.What (if anything) would need to be called out in the CHANGELOG for the next release:
(Hopefully) updated changelog appropriately.