Do not raise misleading warning #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the input `input_files` is not defined, the `config.input_files` will default to an empty array, which always evaluate to true - that was triggering a warning like "hey man, the value you inputted on `input_files` didn't yield any files", which is logically wrong if `input_files` isn't explicitly defined.
|
@softprops can we merge this? would fix the following warning ("not include valid file") always being thrown whenever input_files is not defined. |
|
|
|
@Drowze this makes a lot of sense to me! |
|
this should be available in the new v2 tag |
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/renovate-bot
Mar 9, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [softprops/action-gh-release](https://togithub.com/softprops/action-gh-release) | action | patch | `v2.0.0` -> `v2.0.1` | --- ### Release Notes <details> <summary>softprops/action-gh-release (softprops/action-gh-release)</summary> ### [`v2.0.1`](https://togithub.com/softprops/action-gh-release/releases/tag/v2.0.1) [Compare Source](https://togithub.com/softprops/action-gh-release/compare/v2.0.0...v2.0.1) - Add support for make_latest property [https://github.com/softprops/action-gh-release/pull/304](https://togithub.com/softprops/action-gh-release/pull/304) via [@​samueljseay](https://togithub.com/samueljseay) - Fail run if files setting contains invalid patterns [https://github.com/softprops/action-gh-release/pull/384](https://togithub.com/softprops/action-gh-release/pull/384) via [@​rpdelaney](https://togithub.com/rpdelaney) - Add support for proxy env variables (don't use node-fetch) [https://github.com/softprops/action-gh-release/pull/386](https://togithub.com/softprops/action-gh-release/pull/386)/ via [@​timor-raiman](https://togithub.com/timor-raiman) - Suppress confusing warning when input_files is empty [https://github.com/softprops/action-gh-release/pull/389](https://togithub.com/softprops/action-gh-release/pull/389) via [@​Drowze](https://togithub.com/Drowze) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the input
input_filesis not defined, theconfig.input_fileswill default to an empty array, which always evaluate to true - that was triggering a misleading warning suggesting that the user did input something but the input didn't point to any file.As a fix, simply check if the array is empty as well :)