-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Existing releases are no longer updated #445
Comments
We're also running into this issue after upgrading to v2. |
We have the same issue. Both v1 and v2 do not work anymore. |
We are having this problem now, so with each release I have to manually download all the assets from 5 releases, delete them, and upload them all to a 6th, which is quite annoying. |
Related: softprops/action-gh-release#445 We may need to find an alternative in future
Yeah same issue, surprised this still has yet to be fixed. |
Does anyone know another action which can replace this one? Now that this one no longer works and seems to be unmaintained or slowly maintained. |
I found a solution that worked for me. While I’m not entirely sure if it's directly related to this issue, it might be helpful. The action was functioning well before, but after an update, I encountered the error: "Pattern * does not match any files," similar to the issue in #414. As a result, no files were uploaded. After extensive searching, I discovered that the paths I had specified in the action were directories instead of files. (I used ls -l for debugging, as in #79) Now, I use the following step to upload all files from my build folder, and it works perfectly:
I hope this helps you as well. |
When used in a matrix, uploading files with different names to the same tag will only work properly in a few cases, and most of the time it will report an error.
|
Setting the job It looks like a race condition on the GitHub side if the same release is being created at the same time by different jobs. The action should wait a little and retry in this specific error. |
The purpose of using matrix is to make the job run concurrently. Your solution of However, I thought, if I upload the matrix compilation result to Artifacts, and then create a new matrix, each matrix downloads the compilation result from Artifacts and uploads it to the release of the same tag, I wonder if this problem can be solved temporarily by setting I will test whether it is feasible Is it possible that before uploading the result of matrix compilation, I can create an empty tag using |
Each matrix job is a separate job running in parallel, meaning each job will try to create or modify the related tagged release. It's possible to upload the artifacts and then create the release at once on another independent job, but this can be painful on some workflows. To change the tag name you'll need to source a different action that can do this. I also tried ncipollo/release-action@v1 and it produced the same I suggest you try to create an empty release beforehand with the same tag and release type in a step allowed to fail, like this: - name: Prepare Release
uses: softprops/action-gh-release@v2
continue-on-error: true
with:
tag_name: mytag
make_latest: true
- name: Publish Release
uses: softprops/action-gh-release@v2
with:
tag_name: mytag
make_latest: true
files: ....
body_path: ....
Looks like this worked out in my case. It's not an actual fix, but it will give some headroom to the GitHub API. |
Regarding the problem of uploading files to the same tag name using matrix, I found the ultimate solution and shared it with those who need it.Solution 1with performance loss Although this method can avoid the problem, it will lose the advantage of matrix parallelism. Solution 2This method requires an extra step to create a tag name without files, and then upload the required matrix in parallel to the previously created tag name. This method has better performance and does not lose the advantage of parallel execution of the matrix. I hope these two solutions can help those in need. @lpil @lincolnthalles @andrew121410 @manuelkienlein @debdutdeb |
Related: softprops/action-gh-release#445 We may need to find an alternative in future
Related: softprops/action-gh-release#445 We may need to find an alternative in future
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> Downgrade `softprops/action-gh-release` to 2.0.5 to fix the release per asset mess. It works in https://github.com/nushell/nushell/actions/runs/11809766842 with the release draft: https://github.com/nushell/nushell/releases/tag/untagged-c055298a78ddb780bd01, more detail could be found here: softprops/action-gh-release#445 # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
This is to work around softprops/action-gh-release#445 --------- Co-authored-by: Quentin Gliech <[email protected]>
Related: softprops/action-gh-release#445 We may need to find an alternative in future
You can use gh release upload relase_name file_path to upload file to a existing relase, for example:
|
Thank you @capric8416 ! |
I currently use a matrix to generate jobs, each has the same payload just different file when creating a release.
https://github.com/debdutdeb/novm/blob/cf13d8741fee6959d72dd8bae05cdb5750ca30e9/.github/workflows/release.yaml#L20-L44
This used to just update the existing release with the new files (adding one by one as they are built), noticed recently, that isn't the case anymore. I've been getting
Validation Failed: {"resource":"Release","code":"already_exists","field":"tag_name"}
Looking at the changes, I think the problem lies in #386 although don't know exactly what, likely octokit is adding something more to the request causing this to fail. Or more likely doing some pre-flight checks like "does the tag exist?".
Trying the commit right before this one, seems to have helped my workflow to work again.
commit
your commit
workflow result
The text was updated successfully, but these errors were encountered: