Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rustc dependencies for containerised CI #44

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

jacob-hughes
Copy link
Collaborator

rustgc is now CI'd on a minimal docker container on the soft-dev build server. We need to explicitly install the rustc dependencies for each build.

@jacob-hughes
Copy link
Collaborator Author

bors try

@bors
Copy link

bors bot commented Jan 17, 2022

try

Build failed:

@jacob-hughes
Copy link
Collaborator Author

bors try

@bors
Copy link

bors bot commented Jan 17, 2022

try

Build succeeded:

@jacob-hughes
Copy link
Collaborator Author

That's not quite right. It happened too fast

@@ -0,0 +1,3 @@
FROM debian:bullseye
RUN apt-get update && \
apt-get -y install build-essential curl cmake python3 git ninja-build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll at least need to add something like:

WORKDIR /ci
COPY . .
CMD sh -x .buildbot.sh

@jacob-hughes
Copy link
Collaborator Author

bors try

@bors
Copy link

bors bot commented Jan 17, 2022

try

Build failed:

@jacob-hughes
Copy link
Collaborator Author

bors try

@bors
Copy link

bors bot commented Jan 17, 2022

try

Build succeeded:

@jacob-hughes
Copy link
Collaborator Author

bors try

@bors
Copy link

bors bot commented Jan 17, 2022

try

Build failed:

@jacob-hughes
Copy link
Collaborator Author

bors try

@bors
Copy link

bors bot commented Jan 17, 2022

try

Build failed:

@jacob-hughes
Copy link
Collaborator Author

bors try

@bors
Copy link

bors bot commented Jan 17, 2022

try

Build failed:

@jacob-hughes
Copy link
Collaborator Author

bors try

@bors
Copy link

bors bot commented Jan 17, 2022

try

Build failed:

@jacob-hughes
Copy link
Collaborator Author

bors try

@bors
Copy link

bors bot commented Jan 17, 2022

try

Build failed:

@vext01
Copy link
Member

vext01 commented Jan 18, 2022

thread 'net::tcp::tests::clone_accept_smoke' panicked at 'received error for TcpListener::bind(&addr): Cannot assign requested address (os error 99)', library/std/src/net/tcp/tests.rs:581:17

Does the docker container need networking capabilities?

@ltratt
Copy link
Member

ltratt commented Jan 18, 2022

I think it will at least need to be able to bind 127.0.0.1, which presumably it can't currently do?

@vext01
Copy link
Member

vext01 commented Jan 18, 2022

I'm not sure.

@jacob-hughes Maybe a good place to start: https://docs.docker.com/network/

@vext01
Copy link
Member

vext01 commented Jan 18, 2022

(After checking what address these tests want to bind to)

@jacob-hughes
Copy link
Collaborator Author

bors try

@bors
Copy link

bors bot commented Jan 18, 2022

try

Build failed:

@jacob-hughes
Copy link
Collaborator Author

bors try

@bors
Copy link

bors bot commented Jan 18, 2022

try

Build succeeded:

@jacob-hughes
Copy link
Collaborator Author

Looks like that did it! Let me know if you're happy for me to squash.

@ltratt
Copy link
Member

ltratt commented Jan 18, 2022

Please squash.

@jacob-hughes
Copy link
Collaborator Author

Squashed

@ltratt
Copy link
Member

ltratt commented Jan 18, 2022

bors r+

@bors
Copy link

bors bot commented Jan 18, 2022

Build succeeded:

@bors bors bot merged commit 29c5ba8 into softdevteam:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants