-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rustc dependencies for containerised CI #44
Conversation
bors try |
tryBuild failed: |
bors try |
tryBuild succeeded: |
That's not quite right. It happened too fast |
.buildbot_dockerfile_debian
Outdated
@@ -0,0 +1,3 @@ | |||
FROM debian:bullseye | |||
RUN apt-get update && \ | |||
apt-get -y install build-essential curl cmake python3 git ninja-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll at least need to add something like:
WORKDIR /ci
COPY . .
CMD sh -x .buildbot.sh
bors try |
tryBuild failed: |
bors try |
tryBuild succeeded: |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
Does the docker container need networking capabilities? |
I think it will at least need to be able to bind 127.0.0.1, which presumably it can't currently do? |
I'm not sure. @jacob-hughes Maybe a good place to start: https://docs.docker.com/network/ |
(After checking what address these tests want to bind to) |
bors try |
tryBuild failed: |
bors try |
tryBuild succeeded: |
Looks like that did it! Let me know if you're happy for me to squash. |
Please squash. |
c44241f
to
fe04975
Compare
Squashed |
bors r+ |
Build succeeded: |
rustgc is now CI'd on a minimal docker container on the soft-dev build server. We need to explicitly install the rustc dependencies for each build.