-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug with painting mentions over PDF? #11
Comments
Indeed, in the current version it can happen when the underlying paper has changed. The GUI fetches the Open Access PDF at URL given by a call to the Unpaywall API, but if the version of the PDF has changed between the time the annotations was produced and stored in the KB and now, we have position "mismatch" for the annotations. For example, the annotations produced in 2021 was made with the preprint, and now Unpaywall points to the Gold version of the article. I store a hash for the PDF originally annotated, so I could detect normally if the fetched PDF is still the same of not - but this is not yet implemented. Then if the PDF mismatch is detected we could imagine a fallback solution, like trying alternative URL to get other version of the PDF or re-annotating on the fly. |
Makes sense. Maybe we should store something that enables us to hit the same version (if at all possible)? That's hard without storing the actual article (which we can't do), but perhaps re-trying the URL (or following the metadata to the same version). But also highlight that unpaywall has a new version? |
I think I didn't store the original download url when I did this first experiment, but it will be store next version this year. It can help, but we can also expect that URL change over time even for the same version of the PDF.
Yes, and Unpaywall prioritizes gold version - the "right" older version might still be in the alternative URL given by Unpaywall. I must say I didn't really spend time on this at the time, it's only now after two years that the "live" downloaded PDF starts to be different from time to time and that the problem is visible. |
Yeah, I don't think it's a priority. Maybe stick a note on the page
saying. If you notice issues it might be that the underlying PDF has
changed and point to this issue?
…On Wed, Apr 5, 2023 at 12:55 PM Patrice Lopez ***@***.***> wrote:
Maybe we should store something that enables us to hit the same version
(if at all possible)?
I think I didn't store the original download url when I did this first
experiment, but it will be store next version this year. It can help, but
we can also expect that URL change over time even for the same version of
the PDF.
But also highlight that unpaywall has a new version?
Yes, and Unpaywall prioritizes gold version - the "right" older version
might still be in the alternative URL given by Unpaywall.
I muss say I didn't really spend time on this at the time, it's only now
after two years that the "live" downloaded PDF starts to be different from
time to time and that the problem is visible.
—
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAWOUWWVCWIP26DO6E2EKTW7WW2NANCNFSM6AAAAAAWULERGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I was playing around and noticed this issue, seems like the mentions are being painted on the wrong page, perhaps? or maybe the underlying PDF changed?
https://cloud.science-miner.com/software_kb/frontend/document.html?id=611a11d8e8d4855847028e44
Hopefully this screenshot shows the issue (This is with Firefox 109.0.1 on Mac OS btw)
The text was updated successfully, but these errors were encountered: