Upgrade 3.0.0-SNAPSHOT #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guanchao-yang
requested changes
Oct 23, 2018
| @@ -2,7 +2,7 @@ language: java | |||
| sudo: false | |||
|
|
|||
| jdk: | |||
| - openjdk7 | |||
There was a problem hiding this comment.
这里 JDK7 和 JDK8 都保留吧，历史的组件还没有升级上来，所以两种测试场景都保留吧。
glmapper
reviewed
Oct 31, 2018
| @@ -182,7 +182,7 @@ public void testDoServerReport() throws Exception { | |||
| //ss TL | |||
| this.remoteTracer.serverSend("0"); | |||
| //异步汇报,所以 sleep 10s | |||
| Thread.sleep(1000 * 10); | |||
| Thread.sleep(1000); | |||
glmapper
reviewed
Oct 31, 2018
| @@ -225,7 +225,7 @@ public void testDoReport() throws Exception { | |||
| //ss TL | |||
| this.remoteTracer.serverSend("0"); | |||
| //异步汇报,所以 sleep 10s | |||
| Thread.sleep(1000 * 10); | |||
| Thread.sleep(1000); | |||
glmapper
reviewed
Oct 31, 2018
| String fromApp = "client"; | ||
| String toApp = "server"; | ||
| String fromApp = "server"; | ||
| String toApp = "client"; |
There was a problem hiding this comment.
这里的修改 fromApp & toApp 的 位置是什么原因？
There was a problem hiding this comment.
对着之前的测试代码逻辑看下，改完之后是对的~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade 2.3.0-SNAPSHOT