Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ut issue #492

Merged
merged 1 commit into from
Aug 29, 2022
Merged

fix ut issue #492

merged 1 commit into from
Aug 29, 2022

Conversation

nobodyiam
Copy link
Member

Motivation:

Try to fix the ci failed issue.

Modification:

Use spring profile to set the config value.

Result:

Fixes #490.

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes size/XS labels Aug 27, 2022
@codecov
Copy link

codecov bot commented Aug 27, 2022

Codecov Report

Merging #492 (1744699) into master (cdbde41) will increase coverage by 0.62%.
The diff coverage is 76.08%.

@@             Coverage Diff              @@
##             master     #492      +/-   ##
============================================
+ Coverage     46.30%   46.93%   +0.62%     
- Complexity      219      224       +5     
============================================
  Files           331      332       +1     
  Lines          9916     9946      +30     
  Branches        943      950       +7     
============================================
+ Hits           4592     4668      +76     
+ Misses         4840     4794      -46     
  Partials        484      484              
Impacted Files Coverage Δ
...ource/tracer/DataSourceClientStatJsonReporter.java 94.11% <0.00%> (ø)
...atasource/tracer/DataSourceClientStatReporter.java 0.00% <0.00%> (ø)
...java/com/alipay/common/tracer/core/SofaTracer.java 71.97% <0.00%> (ø)
...er/core/configuration/SofaTracerConfiguration.java 77.46% <ø> (ø)
.../tracer/core/reporter/digest/DiskReporterImpl.java 90.74% <ø> (+3.70%) ⬆️
...at/manager/SofaTracerStatisticReporterManager.java 75.47% <60.00%> (-2.08%) ⬇️
...com/alipay/common/tracer/core/utils/DateUtils.java 75.00% <75.00%> (ø)
...acer/plugins/datasource/utils/DataSourceUtils.java 68.36% <81.48%> (+4.57%) ⬆️
...racer/core/context/span/SofaTracerSpanContext.java 79.22% <100.00%> (ø)
.../tracer/core/registry/AbstractTextB3Formatter.java 59.15% <100.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nobodyiam
Copy link
Member Author

@glmapper

It looks like this pr fixes the ci failed issue.
However, the code changes relate to the changes from #199 that you authored(original change1, original change2), would you please help to review?

@nobodyiam nobodyiam requested a review from glmapper August 27, 2022 14:45
Copy link
Contributor

@glmapper glmapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glmapper glmapper merged commit 20015ba into sofastack:master Aug 29, 2022
@nobodyiam nobodyiam deleted the fix-490 branch August 30, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failed in the master branch
2 participants