Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zipkin plugin #131

Merged
merged 18 commits into from
Dec 14, 2018
Merged

Zipkin plugin #131

merged 18 commits into from
Dec 14, 2018

Conversation

glmapper
Copy link
Contributor

Motivation:

Zipkin plugin

@glmapper glmapper mentioned this pull request Nov 21, 2018
Closed
@glmapper glmapper self-assigned this Nov 21, 2018
@glmapper glmapper added enhancement New feature or request help wanted Extra attention is needed labels Nov 21, 2018
@glmapper glmapper added this to the 2.3.0 milestone Nov 21, 2018
@coveralls
Copy link

coveralls commented Nov 21, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 374

  • 104 of 128 (81.25%) changed or added relevant lines in 6 files are covered.
  • 48 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.5%) to 63.7%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sofa-tracer-plugins/sofa-tracer-zipkin-plugin/src/main/java/com/alipay/sofa/tracer/spring/zipkin/initialize/ZipkinReportRegisterBean.java 19 20 95.0%
sofa-tracer-plugins/sofa-tracer-zipkin-plugin/src/main/java/com/alipay/sofa/tracer/spring/zipkin/properties/ZipkinProperties.java 0 1 0.0%
sofa-tracer-plugins/sofa-tracer-zipkin-plugin/src/main/java/com/alipay/sofa/tracer/spring/zipkin/adapter/ZipkinV2SpanAdapter.java 67 76 88.16%
sofa-tracer-plugins/sofa-tracer-zipkin-plugin/src/main/java/com/alipay/sofa/tracer/spring/zipkin/ZipkinSofaTracerSpanRemoteReporter.java 11 24 45.83%
Files with Coverage Reduction New Missed Lines %
tracer-core/src/main/java/com/alipay/common/tracer/core/registry/AbstractTextB3Formatter.java 1 76.12%
sofa-tracer-plugins/sofa-tracer-httpclient-plugin/src/main/java/com/alipay/sofa/tracer/plugins/httpclient/interceptor/SofaTracerAsyncHttpInterceptor.java 1 94.12%
tracer-sofa-boot-starter/src/main/java/com/alipay/sofa/tracer/boot/listener/SofaTracerConfigurationListener.java 2 84.62%
sofa-tracer-plugins/sofa-tracer-httpclient-plugin/src/main/java/com/alipay/sofa/tracer/plugins/httpclient/interceptor/AbstractHttpRequestInterceptor.java 3 86.11%
tracer-core/src/main/java/com/alipay/common/tracer/core/reporter/digest/AbstractDiskReporter.java 4 78.26%
tracer-core/src/main/java/com/alipay/common/tracer/core/samplers/SofaTracerPercentageBasedSampler.java 6 71.05%
tracer-core/src/main/java/com/alipay/common/tracer/core/configuration/SofaTracerConfiguration.java 9 84.38%
sofa-tracer-plugins/sofa-tracer-httpclient-plugin/src/main/java/com/alipay/sofa/tracer/plugins/httpclient/HttpClientDigestJsonEncoder.java 22 12.0%
Totals Coverage Status
Change from base Build 352: -0.5%
Covered Lines: 2841
Relevant Lines: 4460
💛 - Coveralls

ujjboy
ujjboy reviewed Dec 9, 2018
View reviewed changes
sofa-tracer-plugins/sofa-tracer-zipkin-plugin/pom.xml Outdated
<dependency>
<groupId>io.zipkin.zipkin2</groupId>
<artifactId>zipkin</artifactId>
<version>2.11.3</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接选最新版本好了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

升级 io.zipkin.zipkin2:zipkin 至2.11.12 ；io.zipkin.zipkin2:zipkin-reporter 至 2.7.13。并且修复一些问题：

  • 1、升级 zipkin 版本值最新版本，新版本 zipkin ui 支持中文
  • 2、去除对 RPC 类型的特殊处理逻辑
  • 3、修改Endpoint计算逻辑
  • 4、对于zipkin中的serviceName，使用按服务节点作为serviceName（依赖appName），不在依赖 span 的 oparetionName

卫恒 added 2 commits December 12, 2018 15:59
@QilongZhang QilongZhang merged commit 8582a8e into sofastack:master Dec 14, 2018
@glmapper glmapper mentioned this pull request Mar 19, 2019
Closed
@glmapper glmapper deleted the zipkin-plugin branch February 20, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ujjboy ujjboy ujjboy approved these changes

@QilongZhang QilongZhang Awaiting requested review from QilongZhang

Assignees

@glmapper glmapper

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@glmapper @coveralls @ujjboy @QilongZhang