Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix spring mvc appname lost #108

Merged
merged 3 commits into from
Nov 8, 2018
Merged

fix spring mvc appname lost #108

merged 3 commits into from
Nov 8, 2018

Conversation

straybirdzls
Copy link
Member

In SpringBoot Env, spring-mvc-digest.log lost the appName.

Before Fix:

2018-11-06 20:00:37.445,,a9feaa4d1541505599746100112444,0.1,http://localhost:8080/httpClientTracer,GET,200,-1B,0B,218ms,http-nio-8080-exec-1

After Fix:

2018-11-06 20:10:27.561,sofabootFrameworkTest,mytest,0.1,http://localhost:8080/httpClientTracer,GET,200,-1B,0B,122ms,http-nio-8080-exec-1,,

@straybirdzls straybirdzls added the bug Something isn't working label Nov 6, 2018
@straybirdzls straybirdzls added this to the 3.0.0 milestone Nov 6, 2018
@straybirdzls straybirdzls self-assigned this Nov 6, 2018
@coveralls
Copy link

coveralls commented Nov 8, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 271

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 79.356%
Totals Coverage Status
Change from base Build 263: 0.02%
Covered Lines: 665
Relevant Lines: 838
💛 - Coveralls

@glmapper glmapper self-requested a review November 8, 2018 12:33
@glmapper glmapper merged commit c41b3e7 into sofastack:3.x Nov 8, 2018
@straybirdzls
Copy link
Member Author

fix #112

straybirdzls added a commit to straybirdzls/sofa-tracer that referenced this pull request Nov 14, 2018
@straybirdzls
fix spring mvc appname lost (sofastack#108)
2ff7f03 
* fix spring mvc appname lost

* fix appname case fail in ci

* remove unuseful codes
QilongZhang pushed a commit that referenced this pull request Nov 16, 2018
@straybirdzls @QilongZhang
Fix spring mvc appname lost (#108) (#122)
11901d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glmapper glmapper glmapper approved these changes

@QilongZhang QilongZhang Awaiting requested review from QilongZhang

Assignees

@straybirdzls straybirdzls

Labels
bug Something isn't working
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@straybirdzls @coveralls @glmapper