Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOFATracer Support Zipkin version 2.X.X #23

Closed
guanchao-yang opened this issue Jul 6, 2018 · 2 comments
Closed

SOFATracer Support Zipkin version 2.X.X #23

guanchao-yang opened this issue Jul 6, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@guanchao-yang
Copy link
Member

Describe

SOFATracer report to Zipkin version is 1.19.2 by default

Expected behavior

SOFATracer report Zipkin client support 2.X.X version

Actual behavior

Only verify Zipkin version 1.19.X

@guanchao-yang guanchao-yang added the enhancement New feature or request label Jul 6, 2018
@guanchao-yang guanchao-yang added this to the 2.1.2 milestone Jul 6, 2018
@guanchao-yang guanchao-yang self-assigned this Jul 6, 2018
@guanchao-yang guanchao-yang removed this from the 2.1.2 milestone Jul 9, 2018
@HuangSheng
Copy link

测试使用zipkin2.9.4版本是OK的,没有兼容性问题,服务端和客户端都使用2.9.4版本,但是zipkin-reporter只能使用1.1.2版本,不能使用2.X.X版本的,那个版本看了下,包名改了,需要做兼容。
附客户端依赖

                <dependency>
			<groupId>io.zipkin.java</groupId>
			<artifactId>zipkin</artifactId>
			<version>2.9.4</version>
		</dependency>
		<dependency>
			<groupId>io.zipkin.reporter</groupId>
			<artifactId>zipkin-reporter</artifactId>
			<version>1.1.2</version>
		</dependency>

@guanchao-yang
Copy link
Member Author

@HuangSheng 可以直接 PR 上来哈,我们兼容掉高低版本的 zipkin-reporter

@guanchao-yang guanchao-yang added this to the 2.2.0 milestone Aug 8, 2018
guanchao-yang added a commit that referenced this issue Oct 19, 2018
Update version to 2.2.0 and update SOFABoot dependencies version to 2…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants