Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracer dependency management #20

Closed
guanchao-yang opened this issue Jul 4, 2018 · 2 comments
Closed

Tracer dependency management #20

guanchao-yang opened this issue Jul 4, 2018 · 2 comments
Assignees
@guanchao-yang
Labels
enhancement New feature or request
Milestone
2.1.2

Comments

@guanchao-yang
Copy link
Member

guanchao-yang commented Jul 4, 2018 •
edited
Loading

Tracer module dependency better, tracer-sofa-boot-starter can run in SOFABoot and Spring Boot。And also we can provide tracer-all depend on other tracer modules.Other components can only depend on tracer-all.
@guanchao-yang guanchao-yang added this to the 2.1.2 milestone Jul 4, 2018
@guanchao-yang guanchao-yang added the enhancement New feature or request label Jul 4, 2018
@guanchao-yang guanchao-yang self-assigned this Jul 4, 2018
@guanchao-yang guanchao-yang mentioned this issue Jul 4, 2018
Merged
@HuangSheng
Copy link

@guanchao-yang 现在的zipkin集成是在tracer-sofa-boot-starter项目中的，我们现在的项目没有使用spring boot，如果想集成的话会很麻烦。建议用plugin的方式做成单独的组件，starter只是简化配置，保证不用boot的项目也可以正常使用

@guanchao-yang
Copy link
Member Author

@HuangSheng 好的。麻烦单独列一个 issue 哈，我们做下改进在后续的迭代中。

@guanchao-yang guanchao-yang mentioned this issue Jul 11, 2018
Closed
guanchao-yang added a commit that referenced this issue Oct 9, 2018
@guanchao-yang
Merge pull request #20 from alipay/master
ce2c8ba 
merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guanchao-yang guanchao-yang

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1.2
Development

No branches or pull requests
2 participants
@HuangSheng @guanchao-yang