-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support prometheus #1280
support prometheus #1280
Conversation
Can we combine prometheus with grafana ? And provide a config for that . So that users can easily use sofarpc with prometheus. Another question, how can we open or close this feature ? |
|
Codecov Report
@@ Coverage Diff @@
## master #1280 +/- ##
============================================
+ Coverage 71.93% 72.02% +0.08%
- Complexity 780 783 +3
============================================
Files 413 414 +1
Lines 17555 17565 +10
Branches 2739 2740 +1
============================================
+ Hits 12629 12652 +23
+ Misses 3532 3521 -11
+ Partials 1394 1392 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation:
#885
Modification:
metrics support prometheus
Result:
Fixes #885