feat: without registry & serverHost in unittest env #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gxcsoccer
commented
Nov 6, 2018
lib/client/consumer.js
Outdated
| @@ -18,7 +18,7 @@ class RpcConsumer extends Base { | |||
| constructor(options = {}) { | |||
| assert(options.interfaceName, '[RpcConsumer] options.interfaceName is required'); | |||
| assert(options.logger, '[RpcConsumer] options.logger is required'); | |||
| assert(options.serverHost || options.registry, '[RpcConsumer] options.registry or options.serverHost at least set one'); | |||
| assert(options.inUnittest || options.serverHost || options.registry, '[RpcConsumer] options.registry or options.serverHost at least set one'); | |||
There was a problem hiding this comment.
加一个标识，eggjs 里 config.unittest.js 配置 inUnittest allowMock 为 true
gxcsoccer
force-pushed
the
feat-no-registry-unittest
branch
from
0fa784d to
4934809
Compare
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
+ Coverage 98.45% 98.45% +<.01%
==========================================
Files 38 38
Lines 1808 1810 +2
==========================================
+ Hits 1780 1782 +2
Misses 28 28
Continue to review full report at Codecov.
|
gxcsoccer
force-pushed
the
feat-no-registry-unittest
branch
from
4934809 to
67840a9
Compare
|
+1 |
|
1.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.