fix: print err if encoder/decoder error (#101)

pump will destroy socket, if destroy socket in cb again.
it will do nothing and error whil not print.

.github/workflows/nodejs.yml

@@ -39,7 +39,7 @@ jobs:
         tar xf zookeeper-3.4.6.tar.gz
         mv zookeeper-3.4.6/conf/zoo_sample.cfg zookeeper-3.4.6/conf/zoo.cfg
         ./zookeeper-3.4.6/bin/zkServer.sh start
-        npm i -g npminstall && npminstall
+        npm i -g npminstall@5 && npminstall
 
     - name: Continuous Integration
       run: npm run ci

lib/server/connection.js

@@ -57,7 +57,10 @@ class RpcConnection extends Base {
     this._decoder.on('heartbeat', hb => { this._handleHeartbeat(hb); });
     // @refer https://nodejs.org/en/docs/guides/backpressuring-in-streams/
     pump(this._encoder, this.socket, this._decoder, err => {
-      this.close(err);
+      if (err && err.code !== 'ECONNRESET') {
+        // error may throw by encoder/decoder, so should print the stack
+        this.logger.warn('[RpcConnection] error occured on socket: %s, errName: %s, errMsg: %s', this.remoteAddress, err.name, err.stack);
+      }
     });
 
     this._closed = false;
@@ -99,8 +102,8 @@ class RpcConnection extends Base {
 
   close(err) {
     if (this.isClosed) return Promise.resolve();
-
-    this.socket.destroy(err);
+    this._decoder.end();
+    this._encoder.destroy(err);
     return this.await('close');
   }